Make no-output command test deterministic in MockLLM#36
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Handle no outputunit test deterministic across environments by ensuring the mock LLM returns a command that consistently produces no matches and triggers the intended "no output" code path.Description
MockLLMAPI.getCommandForPromptinsrc/llm/index.tsto returngrep '__LOZ_TEST_NO_OUTPUT_9f8b7c__' README.mdfor theFind sfsdfefprompt sogrepruns against a known file with a guaranteed-missing token.Testing
npm run buildwhich succeeded and rannpm test -- --grep "Handle no output"which produced1 passingfor the targeted test; runningnpm test -- test/command.test.tsshowed the targetedHandle no outputcase passed while other unrelated tests failed due to environment-dependent services and missing API credentials.Codex Task